cloudshiftchris
commented
1 year ago Workaround: run ktfmt directly to avoid mixing class paths:
val ktfmt by configurations.creating
dependencies { ktfmt("com.facebook:ktfmt:0.44") }
val ktfmtFormat by
tasks.registering(JavaExec::class) {
val ktfmtArgs =
mutableListOf("--kotlinlang-style", layout.projectDirectory.asFile.absolutePath)
if (System.getenv()["CI"] != null) ktfmtArgs.add("--set-exit-if-changed")
group = "formatting"
description = "Run ktfmt"
classpath = ktfmt
mainClass.set("com.facebook.ktfmt.cli.Main")
// jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
args(ktfmtArgs)
}
val check = tasks.named("check") { dependsOn(ktfmtFormat) }
tasks.register("precommit") { dependsOn(check) }
cortinico
⚠️ Current behavior
Applying v0.13.0 to a project results in these issues:
Exception compiling Kotlin code when ktfmt plugin applied:
Same exception happens on sync when applying plugin to build-logic (included build w/ convention plugins).
✅ Expected behavior
Applying the ktfmt plugin does not cause exceptions or interfere with other settings.
💣 Steps to reproduce
Install ktfmt plugin via a convention plugin, onto a project using Kotlin 1.8.22 w/ language level 1.9.0.
📷 Screenshots
Dependencies are whacked:
📱 Tech info
Gradle 8.2.1 / Java 19 (same issue with Java 17) / plugin 0.13.0 / Kotlin 1.8.22 (language level 1.9.0)
Seems like the plugin could benefit from running ktfmt using either class loader isolation or shaded dependencies to avoid collisions with likely-to-conflict dependencies (the Kotlin setup needed to build an application will frequently differ from the Kotlin setup needed by ktfmt to parse code).