Fix task caching for ktfmtCheck task with multiple sourceSets - Githubissues

cortinico / ktfmt-gradle

A Gradle plugin to apply ktfmt to your builds, and reformat you Kotlin source code like a glimpse 🧹🐘

MIT License

149 stars 20 forks source link

Fix task caching for ktfmtCheck task with multiple sourceSets #289

Closed simonhauck closed 3 months ago

simonhauck commented 3 months ago

🚀 Description

Add a test to check if the task caching works for ktfmtCheck task with multiple different sourceSets (If both contain the same amount if files, the file is identical and therefore the task caching works)
Append the task name to the outputFile. This seems to be easier then the sourceSet name, because the sourceSet name would have to be passed in in the ktfmtBaseTask.

📄 Motivation and Context

Fixes https://github.com/cortinico/ktfmt-gradle/issues/288

🧪 How Has This Been Tested?

An integration test was added. Before the changes, the test fails.

📦 Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

If you see the outputFile as part of the public API, then this would be a breaking change. I am not aware of a real usecase for the file.

✅ Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

simonhauck commented 3 months ago

Thank's for reviewing and merging it so quickly 👍