search

cortinico / ktfmt-gradle

A Gradle plugin to apply ktfmt to your builds, and reformat you Kotlin source code like a glimpse 🧹🐘
MIT License
149 stars 20 forks source link

[Chore] Remove usage of internal & deprecated methods in preparation for gradle 8.9 #317

Closed simonhauck closed 1 month ago

simonhauck commented 1 month ago

🐛 Describe the bug

Some methods in the build.gradle.kts are deprecated and in gradle 8.9 also internal. This should be fixed.

⚠️ Current behavior

The build fails with gradle 8.9 and uses deprecated methods

✅ Expected behavior

Gradle 8.9 works and the files do not use deprecated methods

💣 Steps to reproduce

📷 Screenshots

📱 Tech info

cortinico commented 1 month ago

Some methods in the build.gradle.kts are deprecated and in gradle 8.9 also internal. This should be fixed.

If you're referring to:

https://github.com/cortinico/ktfmt-gradle/blob/75c91b689895da29731d667e27859be21d72c62c/plugin-build/plugin/build.gradle.kts#L67-L72

Yup that can probably go now to unblock 8.9 migration

simonhauck commented 1 month ago

Yes, I would also remove the other deprecated calls.

I think it is also possible now with testKit to simplify the dependency setup. I will see what is possible and create a PR

cortinico commented 1 month ago

Sure let's do it 👍