Closed simonhauck closed 1 month ago
@cortinico It seems that the dependency is not really required. If you are okay with it, I would remove it.
Which dependency do you mean?
The plugin
id("app.cash.sqldelight") version "2.0.2"
in the example build.gradle.kts
I'd rather keep it. It was added due to https://github.com/cortinico/ktfmt-gradle/issues/158 to have a test bed to make sure we don't break compatibility with sqldelight
I see. I tried to figure out what happens, but maybe this is a bug in SqlDelight itself https://github.com/cashapp/sqldelight/issues/5256.
We could try to add tasks.verifySqlDelightMigration { enabled = false }
.
I checked that the kotlin stubs will still be generated, so we would notice if something breaks. But maybe this exception no longer occurs in the logs
I'd say let's just disable the task as you suggest as at the end of the day we care about the generated code
🐛 Describe the bug
The build log reports always an exception
Log Entry
```shell > Task :example:verifyMainDatabaseMigration Changing log factory from null to null java.lang.Throwable at com.intellij.openapi.diagnostic.Logger.logFactoryChanged(Logger.java:79) at com.intellij.openapi.diagnostic.Logger.setFactory(Logger.java:70) at com.alecstrong.sql.psi.core.ApplicationEnvironment.⚠️ Current behavior
An exception is in every build log. This can be a bit confusing at first.
✅ Expected behavior
The log contains only exceptions if something is wrong.
@cortinico It seems that the dependency is not really required. If you are okay with it, I would remove it.
💣 Steps to reproduce
📷 Screenshots
📱 Tech info