search

cortner / JuLIPMaterials.jl

Collection of Tools for Computational Materials Science
Other
9 stars 3 forks source link

master branch to julia v0.6? #6

Closed lifelemons closed 6 years ago

lifelemons commented 6 years ago

Hey,

So I made some tiny changes to some files to get the module working in v0.6. (i.e. it doesn't throw any errors when one loads it, using MaterialsScienceTools.

(I saw there is a 'cleanup' branch, but missing functionality, at least the bit I needed was in the master branch.)

So this modified version currently exist as a fork on my account (https://github.com/lifelemons/MaterialsScienceTools.jl), I was going to submit a pull request, but I think this should be on its own branch and not merged into the master. So the master retains v0.5 compatibility everything works as normal, and this new branch allows what is the essentially master branch to be, at least, loaded into v0.6 (and people can patch things if other functions fail in some other way)

Thoughts?

(I can also send the changes as a git patch, if that's easier)

cortner commented 6 years ago

oh no - did I forget to merge the cleanup branch? do you mind if I review what I have before merging? We may have to rebase your changes onto cleanup. I'll look at this asap!

cortner commented 6 years ago

what is missing in cleanup ?

cortner commented 6 years ago

I'm looking at your fork, and I think I did everything you did there as well. I'm really sorry you had to go through this by yourself.

But I also tried to do a lot more, since there was so much duplicate functionality. (there is still some of that!) So I might have accidentally removed something you need. Do you have a notebook or script that I can try to get to run in order to make sure I have all the functionality you need?

cortner commented 6 years ago

The other thing that would be worthwhile doing now is for you to create a new branch, e.g. 'punit' that you can use to run whatever you need for now and we can clean up sometime in spring.

cortner commented 6 years ago

I've given you push access so you can just push the new branch to my repository

lifelemons commented 6 years ago

No worries! It wasn't much work as you've now seen.

Also saw that you merged cleanup -> master, I'll add the functions if they aren't there, you can then move then around if you want.

cortner commented 6 years ago

That would be great - thank you