search

cortner / PyAMG.jl

Convenience wrapper for PyAMG library
Other
9 stars 7 forks source link

Update to Julia 1.0 #13

Closed tkonolige closed 5 years ago

tkonolige commented 5 years ago

This PR updates PyAMG.jl to be compatible with Julia 1.0. I removed A_ldiv_B! and A_mul_B! as they have been removed. The PyCall syntax is also changed from @pyimport to just pyimport. I also added a Project.toml for the new package manager.

ChrisRackauckas commented 5 years ago

I removed A_ldiv_B! and A_mul_B! as they have been removed.

They weren't removed, just renamed. mul!, ldiv!

tkonolige commented 5 years ago

My bad, fixed.

cortner commented 5 years ago

Looks good to me. Thanks Chris for catching this.

cortner commented 5 years ago

I forgot - did I give you push access? Ie can you merge?

ChrisRackauckas commented 5 years ago

Nope

cortner commented 5 years ago

sorry, I actually mean t @tkonolige - I recently gave somebody access but it was somebody else.

@ChrisRackauckas If you'd like push access I'm happy to give it to you. Do you still use this or have you switched to AMG.jl?

cortner commented 5 years ago

@tkonolige if you are using PyAMG.jl and are planning to keep this running, then I'd be happy to give you push access as well.

Thank you very much in the meantime for upgrading this to 1.0!

ChrisRackauckas commented 5 years ago

I haven't used this in awhile, but would be fine helping you maintain it. It seems like a pretty low maintenance library.

cortner commented 5 years ago

Correct - I just haven’t moved to 1.0 yet. (Need to complete a large project first)