cortoproject / corto

A hierarchical object store for connecting realtime machine data with web applications, historians & more
https://www.corto.io
MIT License
87 stars 14 forks source link

configure does not work with fish shell #611

Closed Dynamic-Gravity closed 6 years ago

Dynamic-Gravity commented 7 years ago
configure (line 7): 'case' builtin not inside of switch block
case $CURRENT_SHELL in
^
from sourcing file configure
        called on standard input

Call it with bash and it works just fine.

Is it possible to make the script for different shells, or is this going to remain solely for bash?

SanderMertens commented 7 years ago

I am not familiar with the fish shell, but if it can be made to work with different shells that would be great!

If you know how the same or similar functionality can be achieved with fish shell, just create a PR and I'll merge it.

Dynamic-Gravity commented 7 years ago

@SanderMertens alright I'll get to work on it. :)

SanderMertens commented 6 years ago

The new buildsystem no longer requires using a configure script, so I'm closing this issue.