search

corvus-ch / rabbitmq-cli-consumer

Consume RabbitMQ messages into any cli program
MIT License
236 stars 36 forks source link

Add the possibility to bind multiple routing keys #14

Closed johnduro closed 6 years ago

johnduro commented 6 years ago

Hi,

I adapted the work of @sterrien in ricbra/rabbitmq-cli-consumer#59 adding the possibility to bind multiple routing key to a queue. I added test to it.

Tell me if you want any modification, i'll be glad to do them !

Thanks !

corvus-ch commented 6 years ago

Thanks @johnduro, your changes are fine. Codeclimate has spotted an issue to be fixed with go fmt. The other complaints I am willing to ignore. And because #13 is now merged, this PR is now in conflict. Can you please resolve this two issues.

johnduro commented 6 years ago

hey @corvus-ch,

I updated my pr but i have errors in Travis CI i cannot reproduce in local, do you have them too ?

corvus-ch commented 6 years ago

Yes I have them but only occasionally. They occur more often on TravisCi. The error is, that empty lines appear in the output during integration tests. So far I was not able to trace them down and I was able to circumvent the issue by rerun the build jobs.

corvus-ch commented 6 years ago

Thanks @johnduro.

johnduro commented 6 years ago

Ah we got those random errors sometimes on circle-ci too, anyway thanks for the 2 PRs !