corvus-ch / rabbitmq-cli-consumer

Consume RabbitMQ messages into any cli program
MIT License
236 stars 36 forks source link

When RabbitMQ server went down, consumer will terminate it execution #42

Closed salvatorecordiano closed 5 years ago

salvatorecordiano commented 5 years ago

This commit will resolve the issue #40 closed.

corvus-ch commented 5 years ago

This looks quite similar to what I have done at https://github.com/corvus-ch/rabbitmq-cli-consumer/blob/5e8ba3309651e5d6e40c18e5b75e6f5c717b9456/main.go#L141.

It looks like my implementation is flawed somehow and I would like to have a test written for the scenario in question.

@salvatorecordiano Would you like to have a look at this or shall I give it a shot?

corvus-ch commented 5 years ago

This PR made me curious and I started digging into the subject. My findings really made me feel bad about what I said in #40. I will reopen #40 and provide a fix for it.