feat: Prometheus Integration

corvus-ch / rabbitmq-cli-consumer

Consume RabbitMQ messages into any cli program

MIT License

236 stars 36 forks source link

Closed estahn closed 5 years ago

estahn commented 5 years ago

This implements #63

@corvus-ch Should it be possible to enable/disable this feature?

estahn commented 5 years ago

@corvus-ch Have you had a chance to look at this pull request?

corvus-ch commented 5 years ago

I only had a quick look but definitely need to have a closer one. Some topics I will need to think about:

Do we need test coverage for metrics collection and how should that look like?
What should happen if the http server errors? Should the consumer continue to run, or stop?
Should collecting and exposing metrics be optional? Maybe add a flag to enable/disable it?

@estahn Maybe you have some input/ideas for me.