search

corvus-dotnet / Corvus.JsonSchema

Support for Json Schema validation and entity generation
Apache License 2.0
96 stars 9 forks source link

Make new name generation optional #383

Closed pawelmon-allclouds closed 2 weeks ago

pawelmon-allclouds commented 2 months ago

Recently introduced https://github.com/corvus-dotnet/Corvus.JsonSchema/commit/a75f2c2504422476dc7f3332771610d98a1e684e commit drastically changed the way file and type names are generated. I suggest to make this optional. You can add a new flag, e.g. --improvedNamingHeuristics, which would default to True, to choose new or prevoius naming convention.

mwadams commented 2 months ago

I'm doing a refactoring which will enable this.

shuebner commented 1 month ago

I may add that the new heuristic leads to ridiculous names whenever there is no title, but only a description. It should really use its parent property name rather than a description, especially when the description consists of many words.

This gem appeared after updating the generating tool: MachineConfig.HoldAllInformationsAboutTheLocationOfTheMachine. And yes, the bad English of the description is part of the joke.

mwadams commented 2 weeks ago

Fixed in #393 - please try the Preview packages on nuget.