coryasilva / Leaflet.ExtraMarkers

Custom Markers for Leaflet JS based on Awesome Markers
MIT License
331 stars 125 forks source link

Cannot change markerColor of icons, other properties work #51

Closed hakan42 closed 4 years ago

hakan42 commented 4 years ago

I am using extramarkers 1.2.1 with leaflet 1.6.0 and font-awesome 4.7.0 (not sure whether font-awesome version is relevant in this case).

I can create icons with different shapes, icon names, icon colors but cannot change "markerColor". The following:

const osmMosqueIcon = L.ExtraMarkers.icon({ icon: 'fa-moon-o', markerColor: 'green', shape: 'round', prefix: 'fa' })

still gives me the standard "red" background svg. Changing the shape, e.g. shape: 'star' works as well.

I have verified in the Chrome network console that the markers_default.png is being successfully loaded.

Any suggestions where I could continue debugging?

coryasilva commented 4 years ago

I think the shape should be "circle".

On Wed, Jun 3, 2020 at 10:11 AM Hakan Tandogan notifications@github.com wrote:

I am using extramarkers 1.2.1 with leaflet 1.6.0 and font-awesome 4.7.0 (not sure whether font-awesome version is relevant in this case).

I can create icons with different shapes, icon names, icon colors but cannot change "markerColor". The following:

const osmMosqueIcon = L.ExtraMarkers.icon({ icon: 'fa-moon-o', markerColor: 'green', shape: 'round', prefix: 'fa' })

still gives me the standard "red" background svg. Changing the shape, e.g. shape: 'star' works as well.

I have verified in the Chrome network console that the markers_default.png is being successfully loaded.

Any suggestions where I could continue debugging?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/coryasilva/Leaflet.ExtraMarkers/issues/51, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUMSTCKTLJYGNBETIFSYWLRUZ72ZANCNFSM4NR3PCZA .

hakan42 commented 4 years ago

ah, true, it should be "circle"... Amazingly, now I can properly set the markerColor 😊