search

coryasilva / Leaflet.ExtraMarkers

Custom Markers for Leaflet JS based on Awesome Markers
MIT License
330 stars 125 forks source link

Incorrect type definition for markerColor #68

Closed kancur closed 2 years ago

kancur commented 2 years ago

Hey!

In interface IconOptions, the markerColor should accept HEX color values as well, instead of just predefined strings (it should accept HEX values if svg is true to be precise).

https://github.com/coryasilva/Leaflet.ExtraMarkers/blob/5722ba945cdb20574f980578184d66e50b0d1def/dist/leaflet.extra-markers.d.ts#L16-L18

Here's the implementation, it returns the original color parameter if not found in colorMap https://github.com/coryasilva/Leaflet.ExtraMarkers/blob/5722ba945cdb20574f980578184d66e50b0d1def/src/assets/js/leaflet.extra-markers.js#L46-L61

Thank you! :-)

adammankowski1 commented 1 year ago

@coryasilva are you going to publish this change to npm?

coryasilva commented 1 year ago

@adammankowski1 Good morning; I just published v1.2.2

adammankowski1 commented 1 year ago

@coryasilva Thank you for fast response!