search

corybrunson / ggalluvial

ggplot2 extension for alluvial plots
http://corybrunson.github.io/ggalluvial/
GNU General Public License v3.0
497 stars 34 forks source link

switch aes.flow options ("forward" and "backward") to more intuitive terms? #32

Closed corybrunson closed 5 years ago

corybrunson commented 5 years ago

Description of the issue

The current options for the aes.flow parameter (in geom_flow()) are "forward" and "backward". For clarity and consistency with the lode guidance functions, these should be changed to "rightward" and "leftward" (with the current options deprecated).

See this answer on StackOverflow for a discussion.

corybrunson commented 5 years ago

Revising my thoughts on this: If the x position aesthetic is reversed, for instance, then aes.flow would still operate "forward" or "backward" but not correspondingly "rightward" or "leftward". The current options are also more consistent with the use of coord_flip(). So, if these options should be changed at all, perhaps they should be to "increasing" and "decreasing".

corybrunson commented 5 years ago

The current "forwrard" and "backward" are consistent with the new lode guidance functions. If either terminology is changed, both should be.