corybrunson / ggalluvial

ggplot2 extension for alluvial plots
http://corybrunson.github.io/ggalluvial/
GNU General Public License v3.0
499 stars 34 forks source link

resolve failing checks with tidyr CRAN upgrade #34

Closed corybrunson closed 5 years ago

corybrunson commented 5 years ago

This is from at automated email about v1.0.0, scheduled for CRAN on 2019-09-09:

 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  Did you misspecify an argument?
  1: suppressWarnings(tidyr::gather(dplyr::mutate(titanic_alluvia,
Index = 1:nrow(titanic_alluvia)), "Variable", "Value",
         axes = 1:4, factor_key = TRUE)) at testthat/test-is-alluvial.r:36
  2: withCallingHandlers(expr, warning = function(w)
invokeRestart("muffleWarning"))
  3: tidyr::gather(dplyr::mutate(titanic_alluvia, Index =
1:nrow(titanic_alluvia)), "Variable", "Value", axes = 1:4, factor_key
= TRUE)
  4: ellipsis::check_dots_unnamed() at
/private/tmp/RtmpBEzAiw/R.INSTALL570366266439/tidyr/R/gather.R:95
  5: stop_dots(message = paste0(length(named), " components of
`...` had unexpected names."), dot_names = named, .subclass =
"rlib_error_dots_named")
  6: abort(message, .subclass = c(.subclass, "rlib_error_dots"), ...)

  ══ testthat results
═════════════════════════════════════════════════════════════════════════════════════════════
  [ OK: 12 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
  1. Error: (unknown) (@test-is-alluvial.r#36)

  Error: testthat unit tests failed
  Execution halted
corybrunson commented 5 years ago

This seems to have been due to injudicious manual conversions between alluvia and lodes form in the test script, rather than to fundamental changes in tidyr. After some fixes in 6daec653e0e48c31582f21128b239e274128f383, the package passes the tests with the current devel version of tidyr installed. Plan to resubmit to CRAN on 2019-09-09 and watch out for errors immediately after.

corybrunson commented 5 years ago

v0.10.0 is on CRAN. Leaving this issue open until tidyr v1.0.0 is published.