search

corybrunson / ggalluvial

ggplot2 extension for alluvial plots
http://corybrunson.github.io/ggalluvial/
GNU General Public License v3.0
497 stars 34 forks source link

add formatter param to stat layers #40

Closed corybrunson closed 5 years ago

corybrunson commented 5 years ago

This SO question illustrates a major problem with how the stat layers handle the label aesthetic, namely that they either aggregate numeric values but use default formatting or get confused when numeric values are already formatted into strings. The formatter param of geom_fit_text() can be adapted into ggalluvial and will solve this problem.

corybrunson commented 5 years ago

Related: The internal handling of the label aesthetic is very opaque and should be made clear and consistent across the stat layers.

corybrunson commented 5 years ago

The formatter parameter might work, but it is only relevant to the use of an alluvial stat with a text geom. Moreover, in every use case i've experimented with, the fit-text geom plays well with the alluvial stat. I'm closing this issue for now, though it may be reopened if new needs arise. I'll open a separate issue for the internal handling of the label aesthetic.