Open corybrunson opened 4 years ago
Because the key
and value
parameters came from tidyr::gather()
and tidyr::spread()
, whereas some, probably all, of the internal pivoting will be switched to tidyr::pivot_*()
, this would be a good time to deprecate these and the id
parameters in favor of the x
, stratum
, and alluvium
parameters used by the layers.
There is now a whole book on tidy evaluation, which may be useful for improving the readability and efficiency of the parameter change.
Bump.
Also, as the established to_*_form()
functions may take a while to deprecate, their tidyr::pivot_*()
-based superseders might better be given new names, e.g. pivot_to_*()
, so that both could exist simultaneously.
I understand. I could take a look. There are some useful docs on the rlang website. I think it is worth removing the dep on lazyeval to make things more consistent.
I also spotted a defunct function: dplyr::vars_select()
in the ggalluvial codebase. its stated replacement is tidyselect::eval_select()
.
The convenience functions
is_*_form()
andto_*_form()
need a few upgrades:weight
parameter, whereas the layers have switched toy
, which may cause confusion.to_*_form()
rely ontidyr::gather()
andtidyr::spread()
, which are stable but outdated.to_lodes_form()
cannot handle alluvial data with variabley
(andweight
) values. The new functiontidyr::pivot_longer()
makes this possible, as illustrated in #51. It should be possible to similarly convert from lodes to alluvia form while preservingy
(andweight
) values usingtidyr::pivot_wider()
.For consistency between these functions and the layers, it may be prudent to deprecate
axis[0-9]+
in favor ofx[0-9]+
, which would better harmonize with the naturaly[0-9]+
that would be used to specify variabley
values.