corybrunson / ggalluvial

ggplot2 extension for alluvial plots
http://corybrunson.github.io/ggalluvial/
GNU General Public License v3.0
499 stars 34 forks source link

advice from goodpractice #80

Closed corybrunson closed 3 years ago

corybrunson commented 3 years ago

[The goodpractice package]() automates a number of checks and recommendations for R package developers. I just discovered it and ran it on ggalluvial, obtaining the following advice:

It is good practice to

  ✖ not use "Depends" in DESCRIPTION, as it can cause name
    clashes, and poor interaction with other packages. Use "Imports"
    instead.
  ✖ omit "Date" in DESCRIPTION. It is not required and it
    gets invalid quite often. A build date will be added to the
    package when you perform `R CMD build` on it.
  ✖ not import packages as a whole, as this can cause name
    clashes between the imported packages. Instead, import only the
    specific functions you need.
corybrunson commented 3 years ago

This seems to be done but may be revisited.