Change dimensions of apps and put legends at the bottom

corybrunson / ggalluvial

ggplot2 extension for alluvial plots

http://corybrunson.github.io/ggalluvial/

GNU General Public License v3.0

497 stars 34 forks source link

Change dimensions of apps and put legends at the bottom #88

Closed qdread closed 3 years ago

qdread commented 3 years ago

Resolves issue of app windows not having proper dimensions. I have already deployed the apps with the legends on bottom to the shiny server.

Summary of proposed changes:

Still using knitr::include_app, not iframe, but increased the height to 650px for each one
Legends are placed at bottom in apps. This change also reflected in apps source code in inst folder, and in the vignette itself

corybrunson commented 3 years ago

@qdread could you use pkgdown to re-build the site for this PR, or at least the Shiny article based on the vignette? (pkgdown::build_article("shiny"), i think, in case it's unfamiliar.)

qdread commented 3 years ago

Done! 😀

corybrunson commented 3 years ago

The dimension change seems to have made the window taller but not wider! I'm glad to keep trying, or to just give you push access to this repo so you can experiment. But butting the legend at bottom seems to have helped.