search

corydissinger / raw4j

Other
48 stars 27 forks source link

Added some properties to RedditLinks #3

Closed jfineberg closed 11 years ago

jfineberg commented 11 years ago

is_self, url, and selftext

corydissinger commented 11 years ago

Jordan,

Ack, sorry for closing - I can take these changes in but I'd prefer to have all attributes in camel case if possible. I'll have to double check the Jackson APIs

jfineberg commented 11 years ago

Sorry, I guess I'm new to this. First commit ever on Github.

I had a lot of problems with Jackson until I tried "setIs_self" because the Reddit's json uses a "is_self" property. This is just what I found to work.

Did you end up merging anyways?

corydissinger commented 11 years ago

Yes, I did do the merge. I don't know what I was thinking - I wrote that then checked the existing classes and immediately saw that I had the underscores too haha. For some reason I thought Jackson automagically converted the underscores to camel case....

I'd really like to see more building out of the Reddit and RedditTest classes, though. :)

Thanks for the contribution.

-Cory http://corydissinger.com/ Cell: 717-209-1474

On Thu, Sep 26, 2013 at 7:31 PM, Jordan Fineberg notifications@github.comwrote:

Sorry, I guess I'm new to this. First commit ever on Github.

I had a lot of problems with Jackson until I tried "setIs_self" because the Reddit's json uses a "is_self" property. This is just what I found to work.

Did you end up merging anyways?

— Reply to this email directly or view it on GitHubhttps://github.com/corydissinger/raw4j/pull/3#issuecomment-25212321 .