corydolphin / flask-cors

Cross Origin Resource Sharing ( CORS ) support for Flask
https://flask-cors.readthedocs.io/en/latest/index.html
MIT License
884 stars 138 forks source link

importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated #239

Closed osallou closed 5 years ago

osallou commented 5 years ago

Hi, I get this warning relative to deprecation and future python support removal (got it in many other libs too...) I am using version 3.0.7

.../venv/lib64/python3.7/site-packages/flask_cors/core.py:322: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

and isinstance(obj, collections.Iterable)):

jdevera commented 5 years ago

six should cover this but alas the PR is stuck: https://github.com/benjaminp/six/pull/241

jdevera commented 5 years ago

Related: #243

corydolphin commented 5 years ago

Thank you! Fix is merged as #243 and will be deployed shortly.