search

corydolphin / flask-cors

Cross Origin Resource Sharing ( CORS ) support for Flask
https://flask-cors.corydolphin.com/
MIT License
877 stars 137 forks source link

Deprecation Warning for CORS import #245

Closed zkagin closed 5 years ago

zkagin commented 5 years ago

When using flask_cors and running tests I get the following warning:

.../python3.7/site-packages/flask_cors/core.py:322: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  and isinstance(obj, collections.Iterable)):
corydolphin commented 5 years ago

Hello @kzkagin, can you confirm which version of flask-Cors you are using? Version 3.0.8 (released just yesterday) should fix this issue!

Cheers, Cory On Mon, Jun 10, 2019 at 11:41 AM zkagin notifications@github.com wrote:

When using flask_cors and running tests I get the following warning:

.../python3.7/site-packages/flask_cors/core.py:322: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working and isinstance(obj, collections.Iterable)):

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/corydolphin/flask-cors/issues/245?email_source=notifications&email_token=AADNDKOBCBWLDQY5FD7CHXDPZ2N4HA5CNFSM4HWWG3D2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYUHYKA, or mute the thread https://github.com/notifications/unsubscribe-auth/AADNDKKWNXAG2DO7GIWM2S3PZ2N4HANCNFSM4HWWG3DQ .

zkagin commented 5 years ago

Good timing! I was on 3.0.7. Updated and it is indeed fixed.

corydolphin commented 5 years ago

Glad to hear it. All hail @juanmaneo and @jdevera for doing the work!