search

corydolphin / flask-cors

Cross Origin Resource Sharing ( CORS ) support for Flask
https://flask-cors.readthedocs.io/en/latest/index.html
MIT License
884 stars 139 forks source link

Cors docs #277

Closed bbbart closed 4 years ago

bbbart commented 4 years ago

Added some more documentation on the configuration options and locations of Flask-CORS.

The penultimate commit adds a build requirement to the sphinx docs: sphinxcontrib-httpdomain. Not sure if you're happy with that. Admittedly, the added value seems somewhat limited to me as well as the CORS headers are not known by the extension...

Hope this helps!

corydolphin commented 4 years ago

Added some more documentation on the configuration options and locations of Flask-CORS.

The penultimate commit adds a build requirement to the sphinx docs: sphinxcontrib-httpdomain. Not sure if you're happy with that. Admittedly, the added value seems somewhat limited to me as well as the CORS headers are not known by the extension...

Hope this helps!

I'm not worried about an extra dependency for docs building, as long as read the docs can build it :-) 🤞

bbbart commented 4 years ago

Alright, wonderful. I'll close the issue that kicked this off (#274) as soon as the online documentation has been updated!

corydolphin commented 4 years ago

It took longer than it should've for me to fix the docs build -- had to add a requirements file for the new extension. Docs should be live now.

Thank you very much @bbbart for your help!