search

coryhouse / javascript-development-environment

JavaScript development environment discussed in "Building a JavaScript Development Environment" on Pluralsight
https://app.pluralsight.com/library/courses/javascript-development-environment/table-of-contents
MIT License
297 stars 196 forks source link

security-check fails #24

Closed gbm closed 5 years ago

gbm commented 5 years ago

nsp check (+) Client request error: getaddrinfo ENOTFOUND api.nodesecurity.io api.nodesecurity.io:443

(running nsp check here on it's own just to show the error)

coryhouse commented 5 years ago

nsp was acquired by npm, so it's now built into npm. You no longer need to manually run nsp. Check out this PR for updates on how to run the latest versions.

gbm commented 5 years ago

thx :) i would suggest either editing the course (which is great) or sticking up one of those blue post it notes

Chris-43 commented 5 years ago

What in the hell is going on?

What part of my background is off?

I worked at the Jet Propulsion Laboratory for 25 years. I have held a military security clearance for most of my life. I WAS happily subscribed for months.

I will forward this mess to Cory.

On Wed, Dec 12, 2018, 2:11 PM gregor <notifications@github.com wrote:

nsp check (+) Client request error: getaddrinfo ENOTFOUND api.nodesecurity.io api.nodesecurity.io:443

(running nsp check here on it's own just to show the error)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/coryhouse/javascript-development-environment/issues/24, or mute the thread https://github.com/notifications/unsubscribe-auth/ACfSKq3C-O82x45xWwxW1Dh_fRtWligUks5u4VTIgaJpZM4ZQRLR .

coryhouse commented 5 years ago

I've already added a blue note to the relevant clips in the course. That note was added months ago. Did you guys just overlook it?

@Chris-43 - What is your issue?

gbm commented 5 years ago

I see what happened - yes you are right there is a blue note in the package management section but one is missing in the Automation - Demo: Create Security Check and Share Scripts. [only checking cos I love you ;) ]

coryhouse commented 5 years ago

@gbm - Ah! Great catch! I just submitted a patch to add a callout on that clip, and the following clip as well since it shows calling the security-check clip. Thanks! 💯