search

corymsmith / react-native-fabric

A React Native library for Fabric, Crashlytics and Answers
MIT License
1.31k stars 236 forks source link

Updated gradle & android project to use variables from root project #177

Closed XenorPLxx closed 6 years ago

XenorPLxx commented 6 years ago

I've used changes made to https://github.com/luggit/react-native-config/compare/master...Aranda-Cyber-Solutions-LLC:master?diff=split&name=master as a reference and updated android project so it builds on the React Native 0.56 without problems and it also uses global project variables if those are present.

sibelius commented 6 years ago

can you follow react-native-camera pattern https://github.com/react-native-community/react-native-camera/blob/master/android/build.gradle?

XenorPLxx commented 6 years ago

By follow do you mean use their safeExtGet method?

sibelius commented 6 years ago

yep, and maybe the same defaults

XenorPLxx commented 6 years ago

Okay, I've updated PR to follow that pattern and confirm everything builds just fine in my React Native 0.56 project that uses react-native-fabric.

sibelius commented 6 years ago

tks for the PR

XenorPLxx commented 6 years ago

Sure, happy to help :). Will we be seeing npm package update with merged changes soon?