search

corymsmith / react-native-icons

Quick and easy icons in React Native
MIT License
1.14k stars 141 forks source link

update initWithContentView call with eventDispatcher #103

Closed rt2zz closed 9 years ago

rt2zz commented 9 years ago

I did not really look into the internals here but, using the latest v0.5-rc I was getting a no visible interface error on line 88 controller = [[RCTWrapperViewController alloc] initWithContentView:tab];

It appears react-native 0.11 no requires an eventDispatcher argument(wording?) for this method. Add the already present _eventDispatcher solved the issue (ostensibly)

corymsmith commented 9 years ago

What version of React Native are you using with 0.5-rc?

corymsmith commented 9 years ago

0.5-rc is only for React Native 0.12.x+, if you want to use React Native 0.11 then you'll have to use v 0.4.0 of this module.

rt2zz commented 9 years ago

Ah, my mistake :+1: