search

corymsmith / react-native-icons

Quick and easy icons in React Native
MIT License
1.14k stars 141 forks source link

React Native 0.15.0-rc: Error - Incompatible block types #132

Closed patelsan closed 8 years ago

patelsan commented 8 years ago

I am getting following error after upgrading RN to 0.15.0-rc, any suggestions?

.../node_modules/react-native-icons/ios/ReactNativeIcons/IconTabBarItem/SMXTabBar.m:97:52: Incompatible block pointer types sending 'void (^)(SMXTabBarItem *__strong, NSUInteger, BOOL *)' to parameter of type 'void (^ _Nonnull)(UIView<RCTComponent> * _Nonnull __strong, NSUInteger, BOOL * _Nonnull)'

corymsmith commented 8 years ago

I haven't tested out 0.15.0-rc so may be a breaking change that we'll have to fix

On Mon, Nov 9, 2015 at 10:50 AM, patelsan notifications@github.com wrote:

I am getting following error after upgrading RN to 0.15.0-rc, any suggestions?

.../node_modules/react-native-icons/ios/ReactNativeIcons/IconTabBarItem/SMXTabBar.m:97:52: Incompatible block pointer types sending 'void (^)(SMXTabBarItem *__strong, NSUInteger, BOOL *)' to parameter of type 'void (^ _Nonnull)(UIView<RCTComponent> * _Nonnull __strong, NSUInteger, BOOL * _Nonnull)'

Reply to this email directly or view it on GitHub: https://github.com/corymsmith/react-native-icons/issues/132

patelsan commented 8 years ago

I wish I knew more Objective C to help out with this. Switching to 0.14 for now. Closing the issue as RN version is still RC. Thanks for this great work!

corymsmith commented 8 years ago

I believe that #133 fixes this

patelsan commented 8 years ago

Great. Thanks.

corymsmith commented 8 years ago

Just published 0.6.2 to NPM and it includes this PR