search

corymsmith / react-native-icons

Quick and easy icons in React Native
MIT License
1.14k stars 141 forks source link

Size must be specified in styles #143

Closed simonexmachina closed 8 years ago

simonexmachina commented 8 years ago

I thought this package wasn't working until I realised that I need to specify the size both in the props and in the styles. This seems unexpected to me. Maybe the docs should mention this if it is expected behaviour.

mangogogos commented 8 years ago

From readme:

"Icon style must set a width and height, or the icon will not be visible"

corymsmith commented 8 years ago

We should probably add a check warning to the code since this comes up quite a bit

On Mon, Nov 30, 2015 at 10:49 AM, Jacob Patenaude notifications@github.com wrote:

From readme:

"Icon style must set a width and height, or the icon will not be visible"

Reply to this email directly or view it on GitHub: https://github.com/corymsmith/react-native-icons/issues/143#issuecomment-160704358

markburns commented 8 years ago

Could you add a default value instead of a warning/docs?

Anyone who needs to is going to actually see the size needs changing and work out how to change it themselves.

corymsmith commented 8 years ago

Closing this as support for this library is being discontinued, I highly recommend using https://github.com/oblador/react-native-vector-icons instead as its more fully featured, I've added a warning to the Readme about this as well.