search

corymsmith / react-native-icons

Quick and easy icons in React Native
MIT License
1.14k stars 141 forks source link

error on compiling SMXTabBar.m #144

Closed seanscal closed 8 years ago

seanscal commented 8 years ago

image I'm getting this error when I attempt to build my project. Is this common? Has anyone run into this? Thanks for any info anyone can provide

the first error is line 97 after the first _Nonnull

seanscal commented 8 years ago 
  [[self reactSubviews] enumerateObjectsUsingBlock:^(id  _Nonnull obj, NSUInteger idx, BOOL * _Nonnull stop) {

    SMXTabBarItem *tab = [obj respondsToSelector:@selector(barItem)] ? (SMXTabBarItem*)obj : nil;

    if (tab){
      UIViewController *controller = _tabController.viewControllers[idx];
      controller.tabBarItem = tab.barItem;
      if (tab.selected){
        _tabController.selectedViewController = controller;
      }
    }

  }];

  /*
   [[self reactSubviews] enumerateObjectsUsingBlock:^(SMXTabBarItem *tab, NSUInteger index, BOOL *stop) {
   UIViewController *controller = _tabController.viewControllers[index];
   controller.tabBarItem = tab.barItem;
   if (tab.selected) {
   _tabController.selectedViewController = controller;
   }
   }];*/

}

uncommenting the second part of this and commenting out the first fixes the problem, I assume this is still an issue though, my obj-C isn't sharp enough to solve this myself

corymsmith commented 8 years ago

What version of this library are you using? And what version of React Native? I would guess that your React Nativeis out of date

On Mon, Nov 30, 2015 at 1:45 PM, Scal notifications@github.com wrote:

  [[self reactSubviews] enumerateObjectsUsingBlock:^(id  _Nonnull obj, NSUInteger idx, BOOL * _Nonnull stop) {

    SMXTabBarItem *tab = [obj respondsToSelector:@selector(barItem)] ? (SMXTabBarItem*)obj : nil;

    if (tab){
      UIViewController *controller = _tabController.viewControllers[idx];
      controller.tabBarItem = tab.barItem;
      if (tab.selected){
        _tabController.selectedViewController = controller;
      }
    }

  }];

  /*
   [[self reactSubviews] enumerateObjectsUsingBlock:^(SMXTabBarItem *tab, NSUInteger index, BOOL *stop) {
   UIViewController *controller = _tabController.viewControllers[index];
   controller.tabBarItem = tab.barItem;
   if (tab.selected) {
   _tabController.selectedViewController = controller;
   }
   }];*/

}

uncommenting the second part of this and commenting out the first fixes the problem, I assume this is still an issue though

Reply to this email directly or view it on GitHub: https://github.com/corymsmith/react-native-icons/issues/144#issuecomment-160756491

seanscal commented 8 years ago

I'm using the most current version of this library and react native 0.14.2, is this too out of date?

theoriginalgri commented 8 years ago

_Nonnull was introduced with XCode 7. It looks like you're using a 6.x version?