corymsmith / react-native-icons

Quick and easy icons in React Native
MIT License
1.14k stars 141 forks source link

RN to upgrade to 0.18 icon is not shown #159

Closed mvpdream closed 8 years ago

jonolock91 commented 8 years ago

I'm on 0.19.0 and on Android the icons do not display either.

jacob-russo commented 8 years ago

Same issue here.

xiekw2010 commented 8 years ago

My RN version is 0.19.0.

I do all the steps as the readme guides except step3 include fonts

I do it in my MainActivity

public class MainActivity extends ReactActivity {
    private CodePush _codePush;

    /**
     * Returns the name of the main component registered from JavaScript.
     * This is used to schedule rendering of the component.
     */
    @Override
    protected String getJSBundleFile() {
        return this._codePush.getBundleUrl("index.android.bundle");
    }

    @Override
    protected String getMainComponentName() {
        return "GitFeed";
    }

    /**
     * Returns whether dev mode should be enabled.
     * This enables e.g. the dev menu.
     */
    @Override
    protected boolean getUseDeveloperSupport() {
        return BuildConfig.DEBUG;
    }

    /**
     * A list of packages used by the app. If the app uses additional views
     * or modules besides the default ones, add more packages here.
     */
    @Override
    protected List<ReactPackage> getPackages() {
        // 4. Instantiate an instance of the CodePush runtime, using the right deployment key

        // 5. Add the CodePush package to the list of existing packages
        return Arrays.<ReactPackage>asList(
                new MainReactPackage(), new ReactNativeIcons());
    }
}

I look up the .apk file, all the source file (json and ttf) was included.

But the icons doesn't show in my app.

juncocoa commented 8 years ago

Same issue here,Seeking solutions

Sean-Snow commented 8 years ago

+1

ghamaide commented 8 years ago

+1, RN 0.19.0

cmmouritsen commented 8 years ago

I do not believe this is going to be fixed. Please note this message from the home page of this project:

WARNING: Support for this library is being discontinued, I highly recommend using https://github.com/oblador/react-native-vector-icons instead as its more fully featured.

In order to upgrade to RN 0.19, I had to switch my icons over to react-native-vector-icons. It wasn't too bad. Good luck!

corymsmith commented 8 years ago

That is correct, I recommend migrating over ASAP.

corymsmith commented 8 years ago

Closing this as support for this library is being discontinued, I highly recommend using https://github.com/oblador/react-native-vector-icons instead as its more fully featured, I've added a warning to the Readme about this as well.