Push and pop breaks SMXTabBarIOS

corymsmith / react-native-icons

Quick and easy icons in React Native

MIT License

1.14k stars 141 forks source link

Push and pop breaks SMXTabBarIOS #50

Closed dvdhsu closed 9 years ago

dvdhsu commented 9 years ago

Much like #37, but occurs with just the library, and no views.

To replicate, just make a SMXTabBarIOS, then in one of the tabs, attempt to push another view on top. When that top view is popped, the tab bar (which is on the bottom) is entirely broken.

ios simulator screen shot jun 16 2015 3 15 47 am

dvdhsu commented 9 years ago

Turns out this issue was because of changes in React Native's own RCTTabBar that were not applied back in to this library. I've created a PR that applies such changes back.

(The PR also fixes issues with device rotation, mentioned in the original issue.)

corymsmith commented 9 years ago

Fixed w/ #51