search

corymsmith / react-native-icons

Quick and easy icons in React Native
MIT License
1.14k stars 141 forks source link

Update for react-native >= 0.11 #85

Closed skevy closed 9 years ago

skevy commented 9 years ago

This may not need to be merged right away. But it updates react-native-icons to work with the latest version of react-native (master branch)

corymsmith commented 9 years ago

I already have a branch for this, this change breaks the onPress event handling of tab bar items. You'll see in the branch a couple other tweaks that were needed to get it working

On Thu, Aug 27, 2015 at 10:50 AM, Adam Miskiewicz notifications@github.com wrote:

This may not need to be merged right away. But it updates react-native-icons to work with the latest version of react-native. You can view, comment on, or merge this pull request online at: https://github.com/corymsmith/react-native-icons/pull/85 -- Commit Summary --

skevy commented 9 years ago

Great. Sorry about not checking on that. Wasn't using the tab bar icon part, and was trying to get my project to build.

corymsmith commented 9 years ago

No worries at all! I'll merge those changes in when v0.10.0 is out of RC. It may be now actually, on vacation so hadn't noticed.

On Thu, Aug 27, 2015 at 12:37 PM, Adam Miskiewicz notifications@github.com wrote:

Closed #85.

Reply to this email directly or view it on GitHub: https://github.com/corymsmith/react-native-icons/pull/85#event-393565597