search

corymsmith / react-native-icons

Quick and easy icons in React Native
MIT License
1.14k stars 141 forks source link

0.3.6 breaks RN 0.9.0 #87

Closed jacob-israel-turner closed 9 years ago

jacob-israel-turner commented 9 years ago

I just barely noticed that you changed the dependency to RN 0.10.0 in https://github.com/corymsmith/react-native-icons/commit/075d113f6e339e092458a17fe326f701b8876365, but I thought I'd still post if it's helpful for anyone else.

I get this error when building. I am using react-native-icons@0.3.6 and react-native@0.9.0.

screen shot 2015-09-02 at 18 11 32

As a breaking change, this warrants at least a minor, if not a major, version change.

Switching back to 0.3.5 fixes the problem (haven't tried 0.3.6 with RN 0.10.0).

cutemachine commented 9 years ago

I had the same issue. Updating RN to 0.10.1 solved it for me.

corymsmith commented 9 years ago

I'm away on vacation until the 14th so will do a 0.4.0 for RN 0.11 when its released

On Thu, Sep 3, 2015 at 3:19 AM, Jacob Turner notifications@github.com wrote:

I just barely noticed that you changed the dependency to RN 0.10.0 in https://github.com/corymsmith/react-native-icons/commit/075d113f6e339e092458a17fe326f701b8876365, but I thought I'd still post if it's helpful for anyone else. I get this error when building. I am using react-native-icons@0.3.6 and react-native@0.9.0.

screen shot 2015-09-02 at 18 11 32

As a breaking change, this warrants at least a minor, if not a major, version change.

Switching back to 0.3.5 fixes the problem (haven't tried 0.3.6 with RN 0.10.0).

Reply to this email directly or view it on GitHub: https://github.com/corymsmith/react-native-icons/issues/87

olitomas commented 9 years ago

Any news on this ? I have RN 0.10.1 and RN-icons 0.3.6 but cant get things working. I have tried downgrading RN to 0.10.0 and also the RN-icons to 0.3.5.

Only way i get the icons working is with RN at 0.8.0 and RN-icons 0.3.3.

However I need react 0.10.x because of other modules i need for my project.

corymsmith commented 9 years ago

@olitomas What issues are you having? 0.3.6 should work with 0.10.1, I'm doing an update today with support for 0.11.0. I will let you know when its published to NPM so you can try it out

olitomas commented 9 years ago

The build does not fail on 0.3.6 and 0.10.1 but the icons spots are empty....but no errors though (But they work when i downgrade back to RN 0.8.0 and RN-icons 0.3.3 as stated earlier).

Sounds awesome, thanks so much !

corymsmith commented 9 years ago

Just published 0.4.0 to NPM, should fix things.

olitomas commented 9 years ago

For anyone with the same problem as me, the following steps fixed it:

  1. Build Phases - > Copy Bundle Resources -> '+' -> Add Others -> Select the "FontAwesome.otf" file(node_modules/react-native-icons/ios/ReactNativeIcons/Libraries/FontAwesomeKit/)
  2. Clean Project("CMD + SHIFT + K")
  3. Build and run.