coryo / ComicReader.bundle

Plex Media Server channel for comic archives.
137 stars 8 forks source link

Swipe #2

Open ctv99 opened 8 years ago

ctv99 commented 8 years ago

is there anyway to add swpie to goto next image in set?

coryo commented 8 years ago

could you be a bit more clear on that? I don't quite understand what you mean.

Swiping between images is something that is handled by whichever Plex client you are using. The channel just provides the sequence of images to display.

ctv99 commented 8 years ago

well on the android app no matter what i do it wont swipe between images. Works fine on PC

i have latest app on Samsung note 5.

coryo commented 8 years ago

ok I see what you mean. I tried it on my phone and can't swipe. it works on my ipad.

I'll see if I can get it working. it may also be a bug with the android client.

ctv99 commented 8 years ago

Thanks alot my kids will thank you

coryo commented 8 years ago

I think it's the android client. I posted a bug report on the plex android forum https://forums.plex.tv/discussion/216079/bug-channels-that-serve-images-cant-swipe-left-right-between-photos?new=1

my channels and official plex photo channels both have the issue. I'm pretty sure it used to work. hopefully we can get a response from plex.

coryo commented 8 years ago

Upon further inspection, you can get the swipe behaviour but you have to press the little Play button at the top of the photo album. It works but you always start the the first image.

I'm not sure why this is the default behaviour, but I think it's the best we can do at the moment.

ctv99 commented 8 years ago

is there any way to extract 1st jpg 01.jpg,png or cover.png,jpg an make it the image for the cbz?

coryo commented 8 years ago

I pushed an update which should make covers show more consistently across different plex clients.

Let me know if any comics get assigned the wrong image as the cover. All I'm doing is sorting the files by name and picking the first one. I'm not an expert on comic archive standards, but this seems to work.

It might require a server restart after you update the channel.

ctv99 commented 8 years ago

can i get you to switch unrar to 7za it has better support and my cbz dont like rar

On Fri, Apr 22, 2016 at 10:22 AM Cory Parsons notifications@github.com wrote:

I pushed an update which should make covers show more consistently across different plex clients.

Let me know if any comics get assigned the wrong image as the cover. All I'm doing is sorting the files by name and picking the first one. I'm not an expert on comic archive standards, but this seems to work.

It might require a server restart after you update the channel.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/coryo/ComicReader.bundle/issues/2#issuecomment-213470965

ctv99 commented 8 years ago

here is a test file, it opens in installed winrar but not in plex client with new code

i have 700 name *.cbz

all encoded with 7za due to compression levels

Test.zip

coryo commented 8 years ago

the test zip file appears to be compressed with 7z. It should be named Test.7z or Test.cb7. (open it in 7zip and go file->properties and it says Type: 7z). winrar is being nice and figuring out how to open it regardless of the extension.

7zip looked like it was going to be the hardest to implement with plex/python, so I had just stuck to zip and rar when I wrote the channel.

If you have tons of 7z compressed comics I could maybe investigate implementing 7z but it was looking like it would be easier just to recompress comics with something more python friendly.

Ideally every comic would be cbz since zip is natively supported by python. (and in addition to being named .cbz or .zip, be actually compressed with zip).

ctv99 commented 8 years ago

http://stackoverflow.com/questions/26603204/how-to-extract-7z-zip-file-in-python-2-7-3-version http://codereview.stackexchange.com/questions/69258/python-script-for-automatically-extracting-an-archive-file-in-a-subfolder

does this help and and i have thousands of file redone in 7za because i use comicrack for local pc viewing.

coryo commented 8 years ago

I got something sort of functional going.

Instead of including the 7zip binary like I did with rar, I just have a channel preference for the executable path. So you have to install 7zip on the PMS computer.

set the channel preference to: windows C:\Program Files (x86)\7-Zip\7z.exe linux /usr/bin/7z or run which 7z to find it osx I didn't test.

ctv99 commented 8 years ago

can i set it to the folder path like unrar is now?

coryo commented 8 years ago

you could throw 7z.exe into any folder and set the preference to its path.

if you put it in the channel folder it might get overwritten at some point though.

ctv99 commented 8 years ago

ok, thx alot, in the mean time i wrote a script to convert all files, but this will save me days of recompression