[Request] add read status to folders

[Bart274]

Hi,

I love the read status indicator. I was wondering if you could add this to the parent folders as well. I use the following structure:

\Comic It would be great if you would add the read status as well. The read status would be the following: - Unread: all comics in all subdirectories are unread - Read: all comics in all subdirectories are read - Busy: at least one comic in any subdirectory is (being) read.

[coryo]

I have a demo of this in master branch now.

currently a directory is considered a 'series' if it has 1 or more compatible archives in it. The directory will get its name decorated with one of the indicators based on the status of the archives in it.

<read> Series/
    <read> issue 1
    <read> issue 2

any combination of statuses will result in in progress:

<in progress> Series/
    <read>   issue 1
    <unread> issue 2

It's not currently checking the status of subdirectories. I guess It probably should

<read> Series/
    <unread> Subdirectory/
        <unread> sub-issue 1
        <unread> sub-issue 2
    <read> issue 1
    <read> issue 2    

[Bart274]

Actually it should be:

Series/ ``` Subdirectory/ sub-issue 1 sub-issue 2 ``` issue 1 issue 2 Op 23 mei 2016 om 20:28 heeft Cory Parsons > het volgende geschreven: Series/ Subdirectory/ sub-issue 1 sub-issue 2 issue 1 issue 2

[coryo]

yeah thats how it should be.

I have it completed now so it should handle subdirectories. Hopefully it isn't too slow since it has to do the status check every time it loads a directory.

I have it log the load time now. with ~4k files and 150 folders i'm getting ~150ms load time for the main menu on an i5.

I imagine some people have really huge collections so let me know if it's a problem.

[Bart274]

Thanks a lot! I'll update now and try it immediately :) I have about 43k files :)

Op 23 mei 2016 om 21:52 heeft Cory Parsons notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

yeah thats how it should be.

I have it completed now so it should handle subdirectories. Hopefully it isn't too slow since it has to do the status check every time it loads a directory.

I have it log the load time now. with ~4k files and 150 folders i'm getting ~150ms load time for the main menu on an i5.

I imagine some people have really huge collections so let me know if it's a problem.

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHubhttps://github.com/coryo/ComicReader.bundle/issues/5#issuecomment-221076657

[Bart274]

I just tried it, I have some issues opening the channel now in the ios app and in the web app, it worked before...

[coryo]

with 43k files it may be taking too long to load and giving up.

I added another performance fix which (depending on your directory structure) should make it less intensive.

Also you may need to restart the server for all the code to load properly.

If that doesn't work, there may be an error in the Plex Media Server/Logs/PMS Plugin Logs/com.plexapp.plugins.comicreader.log file.

If it still won't load, you can downgrade by deleting ComicReader.bundle and replacing it with the latest version on the releases page.

[Bart274]

Thanks a lot! I'll try it tomorrow morning! :) I'm still going through my files to organize them properly and to remove all the duplicates :)

Op 24 mei 2016 om 21:30 heeft Cory Parsons notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

with 43k files it may be taking too long to load and giving up.

I added another performance fix which (depending on your directory structure) should make it less intensive.

Also you may need to restart the server for all the code to load properly.

If that doesn't work, there may be an error in the Plex Media Server/Logs/PMS Plugin Logs/com.plexapp.plugins.comicreader.log file.

If it still won't load, you can downgrade by deleting ComicReader.bundle and replacing it with the latest version on the releases page.

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHubhttps://github.com/coryo/ComicReader.bundle/issues/5#issuecomment-221371628

[Bart274]

Ok, I tried the latest version. Now the folders are showing up again. :)

The read status isn't working for subfolders yet? I thought you said you fixed that? Also, all folders are read if I look to them, but all the comics in the folder are unread...

For example:

• Root level (according to this view, you would think all comics are read):
• Marvel directory (according to this view, you would think all comics are read, except the 15-love series which I'm currently reading):
• 15-Love directory (right status):
• Other directory (wrong status):

[coryo]

Sorry for the delay. I have a better implementation in the master branch now.

this should show the correct state, and it should cache the state so it will only be recalculated when something changes.

[Bart274]

It seems to work well! :) Thanks a lot! :)