search

coryodaniel / bonny

The Elixir based Kubernetes Development Framework
MIT License
377 stars 27 forks source link

Implements telemetry for the Operator #244

Closed rafaelgaspar closed 10 months ago

rafaelgaspar commented 10 months ago

Hi, first of all thanks this great project.

The Operator doesn't use the Reconciler's and Watcher's execution logic, it reimplements it directly from get_raw_stream to work better with ControllerV2, but that means that we don't get telemetry data when using an Operator.

This adds telemetry support for the Operator runs.

mruoss commented 10 months ago

Hey @rafaelgaspar

Very nice, thanks. Could you please also add a new entry to the changelog?

rafaelgaspar commented 10 months ago

Since there is no tests for current telemetry implementation I did not add any new tests for this, that's why coveralls is failing, I could add some, but testing telemetry is kind of tricky, I would probably add telemetry_test.

mruoss commented 10 months ago

Yeah I'd consider testing telemetry a topic to tackle separately. You're very welcome to come up with something in a separate PR of course.

mruoss commented 10 months ago

Thanks for your contribution!