Invalid url continues anyway

coryshrmn commented 11 years ago

I haven't been able to reproduce this yet, but during our presentation, when inserting a new website, for URL I input "google." (without quotes). The validation code said ">>>ERROR: Invalid URL" or something along those lines, but instead of prompting me for the correct URL, it continued and asked me for the company name.

Maybe it was in my head.

My best guess is that in WebsiteCatalog.c, line 27:

valid = false;

...needs to be moved one line down, into the do-while loop.

We need to be able to reproduce the bug first.

coryshrmn commented 11 years ago

Reproduced.

Input file name:
>top_25.txt

1 - Insert a Website
2 - Delete a Website by URL
3 - Search for a Website by URL
4 - Print hash buckets
5 - Print BST in order
6 - Print BST indented
7 - Print hash efficiency
8 - Save
9 - Save as...
10 - Quit
>3
Enter URL to search for:
>google.com
google.com
    Company:         "Google"
    Daily Pageviews: 1,000,000,000
    Traffic Rank:    1
    Backlinks:       1,000,775,000
    Worth:           $2,000,000,000

1 - Insert a Website
2 - Delete a Website by URL
3 - Search for a Website by URL
4 - Print hash buckets
5 - Print BST in order
6 - Print BST indented
7 - Print hash efficiency
8 - Save
9 - Save as...
10 - Quit
>1
Enter URL to add:
>google.
>>>ERROR : Invalid input. Please try again.
Enter company name:
>

ghost commented 11 years ago

fixed in master branch: d1d4f8a0b31339a3413ebedc61ac9cb91f524907.

coryshrmn / websitecatalog

Invalid url continues anyway #21