search

cos-archives / hgrid

[UNMAINTAINED] A Javascript-based hierarchical grid that can be used to manage and organize file/folder-like data
Apache License 2.0
23 stars 14 forks source link

HGrid does not interact well with SlickGrid row selection #61

Closed brianjgeiger closed 10 years ago

brianjgeiger commented 10 years ago

This is somewhat of a large and vague bug, but the row selection plugin for SlickGrid doesn't seem to always work with HGrid. I haven't done thorough testing, but with my setup for the Dashboard project organizer, if I have more than two columns, at least one column isn't going to be have its CSS set as selected when it's been selected.

It gets worse with multiple row selection on, but most of the CSS problems clear off if the rows fall far enough away from the visible area and come back. I have attached an animated GIF to show some of the issues and how they interact with various events.

hgrid row selection bugs

sloria commented 10 years ago

Thanks for catching and posting this. I will look further into this when I have more time to put into HGrid.

JeffSpies commented 10 years ago

Is this an essential feature for the dashboard?

On Tuesday, May 20, 2014, Steven Loria notifications@github.com wrote:

Thanks for catching and posting this. I will look further into this when I have more time to put into HGrid.

— Reply to this email directly or view it on GitHubhttps://github.com/CenterForOpenScience/hgrid/issues/61#issuecomment-43633849 .

Sent from an iPhone

brianjgeiger commented 10 years ago

I expect it will be. With more than a few projects, multi-selection drag and drop will be pretty important. And there are some oddities even with single selection, so it would probably be best to have working better even then.

JeffSpies commented 10 years ago

Ok then you and Steve should actively be debugging this. Perhaps involve Lyndsy as well to help root out the problem.

On Tuesday, May 20, 2014, brianjgeiger notifications@github.com wrote:

I expect it will be. With more than a few projects, multi-selection drag and drop will be pretty important. And there are some oddities even with single selection, so it would probably be best to have working better even then.

— Reply to this email directly or view it on GitHubhttps://github.com/CenterForOpenScience/hgrid/issues/61#issuecomment-43655111 .

Sent from an iPhone

brianjgeiger commented 10 years ago

Not actually an HGrid problem directly. My custom rows did not have id fields attached to them, so when updateCellCssStylesOnRenderedRows was updating the CSS selectors based on column id, it would update one column twice rather than each column, as both Modified and Contributors had undefined ids. If there is a change in HGrid, it would be that something should complain if a column doesn't have id defined. Otherwise, this works fine.

sloria commented 10 years ago

@brianjgeiger, can this issue be closed?

brianjgeiger commented 10 years ago

Yes.