Remove removes all objects

[chrisseto]

Assumptions we have a stored object called tag

len(tag.find())  # 20
t = tag.find()[0]
t.remove()
len(tag.find()) # 0

The expected behavior would be that only t is removed from the backend

[jmcarp]

remove is a classmethod of StoredObject, so the expected usage is something like Tag.remove(tag). But yes, remove is still available from instances, which is confusing. Not sure how to improve this--thoughts welcome.

[chrisseto]

def remove(cls):
    if isinstance(cls, StoredObject):
        # Remove just the instance here
    else:
        # Remove everything here

Could that potentially work?

[jmcarp]

Well, cls is always going to be passed as the schema class, never the instance. So I don't think so, unless I'm misunderstanding.

[chrisseto]

Right... sadly that doesnt work. My suggestion under the advice of BrianG would be to rename the cls.remove to cls.remove_all and then implement instance.remove as expected.