cosanlab / nltools

Python toolbox for analyzing imaging data
https://nltools.org
MIT License
120 stars 42 forks source link

check that input to stats.fdr is between 0 and 1 #364

Closed esfinn closed 3 years ago

esfinn commented 3 years ago

Small suggestion: in the stats.fdr function, add a check that the input array is between 0 and 1. (Inspired by the bug on the naturalistic-data site, where we were accidentally correcting r-values instead of p-values -- a check like this would catch that.)

ljchang commented 3 years ago

fixed in #380