search

cosanlab / nltools

Python toolbox for analyzing imaging data
https://nltools.org
MIT License
120 stars 42 forks source link

Drop deepdish for h5py #415

Closed ejolly closed 7 months ago

ejolly commented 1 year ago

Deepdish doesn't seem to be under development any more: https://github.com/uchicago-cs/deepdish/pull/49#issuecomment-1470027826

It also fails for the latest version of numpy 1.24, due to enforced API deprecations. I've currently pinned us to numpy<1.24, but we should drop it as a dependency and switch over to h5py ASAP, which has long term support from the HDF5 team. But this will require a bit of rewriting for how we're saving and loading Brain_Data and Adjacency objects

ljchang commented 9 months ago

@ejolly. Apologies for the delay. Seems like it is reading and writing data ok. I propose merging this and unpinning the old versions of numpy. thanks!

ejolly commented 7 months ago

Done in #416