search

cose-wg / CBOR-certificates

Other
11 stars 7 forks source link

Location of signature algorithm in CSR #170

Closed gselander closed 5 months ago

gselander commented 7 months ago

Missed this in #149. Fixes #167.

emanjon commented 7 months ago

I miss any discussion on this

gselander commented 7 months ago

This is alignment with location of signature algorithm in certificate. As noted in #149, the same argument will apply to the location of the signature algorithm in a CRL. It seems reasonable to be consequent and do so also for the CSR.

emanjon commented 7 months ago

This is alignment with location of signature algorithm in certificate. As noted in https://github.com/cose-wg/CBOR-certificates/issues/149, the same argument will apply to the location of the signature algorithm in a CRL. It seems reasonable to be consequent and do so also for the CSR.

One of the agreement was that we should keep the same location as in X.509. This PR breaks that. You could equally well say that based on previous discussions in is reasonable to not change...

highlunder commented 5 months ago

@gselander to mail and ask/discuss on the COSE list!

gselander commented 5 months ago

Email sent to the COSE list