Closed hannestschofenig closed 1 year ago
There probably should be a table of abbreviations used in mode, kem, kdf and aead instead of repeating the same values multiple times.
On using modes other than base, there needs to be a parameters for the PSK identifier (for psk/authpsk) and sender key ID (for auth/authpsk). For the latter, "static key id" probably can be reused, but the first would require a new parameter (with bstr value).
There are very much nontrivial security considerations on using auth/authpsk mode. For one, using those modes with two-layer structure is insecure. These need to be restricted to one-layer structure.
Regarding COSE_KDF_Context: This is what COSE uses for the context information and it is old text from the earlier draft.
Regarding the cipher suite label: I don't want to introduce abbreviation table since we are not using the labels so often.
Regarding the modes other than Base mode: I agree that there is more work needed (including implementation work) but we have to start somewhere.
I suggest the PR be merged.
In this PR I did an overall cleanup:
I also improved the wording of the text in the intro and the abstract.
@dajiaji @selfissued @laurencelundblade @OR13 @ilaril: Please have a quick look at it.