cose-wg / HPKE

3 stars 3 forks source link

Overall Cleanup #33

Closed hannestschofenig closed 1 year ago

hannestschofenig commented 1 year ago

In this PR I did an overall cleanup:

I also improved the wording of the text in the intro and the abstract.

@dajiaji @selfissued @laurencelundblade @OR13 @ilaril: Please have a quick look at it.

ilaril commented 1 year ago
  1. The text seems to recommend using COSE_KDF_Context, which is problematic for two reasons:
  1. There probably should be a table of abbreviations used in mode, kem, kdf and aead instead of repeating the same values multiple times.

  2. On using modes other than base, there needs to be a parameters for the PSK identifier (for psk/authpsk) and sender key ID (for auth/authpsk). For the latter, "static key id" probably can be reused, but the first would require a new parameter (with bstr value).

  3. There are very much nontrivial security considerations on using auth/authpsk mode. For one, using those modes with two-layer structure is insecure. These need to be restricted to one-layer structure.

hannestschofenig commented 1 year ago

Regarding COSE_KDF_Context: This is what COSE uses for the context information and it is old text from the earlier draft.

Regarding the cipher suite label: I don't want to introduce abbreviation table since we are not using the labels so often.

Regarding the modes other than Base mode: I agree that there is more work needed (including implementation work) but we have to start somewhere.

OR13 commented 1 year ago

I suggest the PR be merged.