coshx / portfolio_optimizer

Visualize your optimal stock portfolio
MIT License
1 stars 3 forks source link

Feature/service implementation #12

Closed lane-s closed 8 years ago

mwytock0812 commented 8 years ago

Can we standardize functions to include the opening brace on the function definition line rather than placing the opening brace on its own line?

var add = function(operand1: Number, operand2: Number): Number {
    // important code here
}

...instead of

var add = function(operand1: Number, operand2: Number): Number
{
    // important code here
}
mwytock0812 commented 8 years ago

I'll ask you guys to walk me through bits of the code, but it looks awesome! Only small things I see at the moment are:

  1. Remove the code that prints to the console. At first pass I didn't see it in this pull request, so it might be from an earlier commit (maybe Curtis's PR that fired an event when "Optimize" is clicked?).
  2. The "Starting Value" should actually be the number of symbols divided by the initial investment (equal distribution of the investment). The "Ending Value" should be what is currently the starting value.