cosimameyer / overviewpy

💡 Easily Extracting Information About Your Data in Python
https://cosimameyer.github.io/overviewpy
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Merge data-file-summarizer into overviewpy #17

Open ba66e77 opened 1 year ago

ba66e77 commented 1 year ago

As discussed in Issue #14, moving the functionality of data-file-summarizer into overviewpy.

ba66e77 commented 1 year ago

This PR is a work in progress. Additional work is needed to:

ba66e77 commented 1 year ago

Ok, I've realized there already is a code method to access the summarizer without dropping back to the command line. So I'm caling that one done.

For the last one, I kind of mislove the use of pd as the alias for pandas.

I propose merging the PR as it is and we can adjust code style and stuff after the fact.

ba66e77 commented 1 year ago

Asking around a bit on masstodon, seems like most of the community sees no problem with aliasing pandas as pd. So, since the community is down with it and the rest of the package already uses that nomenclature, I bit the bullet and updated the summarizer to use that convention also.

cosimameyer commented 1 year ago

Thanks again for the PR!

I changed the target branch - this way we can merge all upcoming PRs to an up-to-date base feature branch that mirrors the main branch, and make sure all changes are done as expected before moving them back to main and releasing them :)

Just wondering because there seem to be issues with poetry. What OS are you developing on? I use a docker image for the project (sorry for not mentioning it earlier) - if you feel comfortable with that, it might be good to have that as a common base.

ba66e77 commented 1 year ago

I'm developing on OSX in a conda environment with python 3.10.

What kind of problems are you seeing with poetry?