Closed cosimoNigro closed 3 years ago
Merging #102 (6e474b7) into master (ad70854) will increase coverage by
0.64%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 95.68% 96.33% +0.64%
==========================================
Files 30 30
Lines 2200 2208 +8
==========================================
+ Hits 2105 2127 +22
+ Misses 95 81 -14
Flag | Coverage Δ | |
---|---|---|
unittests | 96.33% <100.00%> (+0.64%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
agnpy/tests/test_synchrotron.py | 100.00% <ø> (ø) |
|
agnpy/tests/test_compton.py | 100.00% <100.00%> (ø) |
|
agnpy/compton/external_compton.py | 98.43% <0.00%> (+10.93%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ad70854...6e474b7. Read the comment docs.
✅ Merging this PR will increase code quality in the affected files by 0.49%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.10 ⭐ | 0.10 ⭐ | 0.00 |
Method Length | 110.20 🙂 | 108.33 🙂 | -1.87 👍 |
Working memory | 9.36 🙂 | 9.28 🙂 | -0.08 👍 |
Quality | 65.77% 🙂 | 66.26% 🙂 | 0.49% 👍 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 658 | 691 | 33 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
agnpy/data/reference_seds/jetset/jetset_ssa_seds.py | 52.24% 🙂 | 52.24% 🙂 | 0.00% |
agnpy/data/reference_seds/jetset/jetset_ssc_seds.py | 57.98% 🙂 | 57.98% 🙂 | 0.00% |
agnpy/tests/test_compton.py | 71.01% 🙂 | 71.67% 🙂 | 0.66% 👍 |
agnpy/tests/test_synchrotron.py | 69.40% 🙂 | 69.40% 🙂 | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
agnpy/tests/test_synchrotron.py | TestSynchrotron.test_ssa_reference_sed | 0 ⭐ | 172 😞 | 14 😞 | 54.13% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
I have also updated the tutorial notebooks to work with the new data and with some of the adjustments we made for the paper. I will add also the gammapy's notebook once we finalise the paper content.
Merging without review since the core library is not affected, only the test and docs.
In this PR I have:
FluxPoints
.