Closed cosimoNigro closed 2 years ago
✅ Merging this PR will increase code quality in the affected files by 6.76%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.00 ⭐ | 0.00 ⭐ | 0.00 |
Method Length | 641.00 ⛔ | 288.00 ⛔ | -353.00 👍 |
Working memory | 14.00 😞 | 12.00 😞 | -2.00 👍 |
Quality | 43.24% 😞 | 50.00% 😞 | 6.76% 👍 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 115 | 59 | -56 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
agnpy/data/mwl_seds/standardise_mwl_sed.py | 43.24% 😞 | 50.00% 😞 | 6.76% 👍 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
I am making a new release after merging this as the SED data have been updated (I also re-run the notebooks).
Merging #110 (d37c359) into master (cac3ae5) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 30 30
Lines 2208 2208
=======================================
Hits 2127 2127
Misses 81 81
Flag | Coverage Δ | |
---|---|---|
unittests | 96.33% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cac3ae5...d37c359. Read the comment docs.
@jsitarek realised that the MWL flux points of PKS1510-089 were in the original format in TeV cm-2 s-1 and not in erg cm-2 s-1. CLASSIC mistake. I fixed them using the data he posted in this discussion in the
agnpy_paper
repo.PKS1510-089 have now an additional column with the instrument specified. Could not do the same for Mrk421 - add an instrument column - as I am stilling waiting for a response from David Paneque.