Closed IlariaViale closed 2 years ago
Thanks a lot @IlariaViale, will review it soon.
Merging #120 (58c9af9) into master (86a28d4) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 30 30
Lines 2233 2233
=======================================
Hits 2166 2166
Misses 67 67
Flag | Coverage Δ | |
---|---|---|
unittests | 96.99% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
agnpy/absorption/absorption.py | 96.36% <100.00%> (ø) |
|
agnpy/tests/test_absorption.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 86a28d4...58c9af9. Read the comment docs.
Thanks @IlariaViale, looks already good to me, it would be good if you can add the Saldana-Lopez paper to the bibliography in the docs.
Then we are ready to merge.
@IlariaViale just one last thing, can you update the documentation page https://agnpy.readthedocs.io/en/latest/absorption.html#extragalactic-background-light and add a reference to the new model that is now available? Can you update the snippet plotting all the EBL models as well? The .rst file for the documentation page is here https://github.com/cosimoNigro/agnpy/blob/master/docs/absorption.rst the snippet, that is executed when the docs are built, is here https://github.com/cosimoNigro/agnpy/blob/master/docs/snippets/ebl_models.py
Thanks Ilaria!
Thanks @IlariaViale, welcome to the development team :)
I added the file ebl_saldana-lopez21.fits.gz to the repo at agnpy/data/ebl_models. It contains data from the work of Saldana-Lopez et al. (2021) [link: https://www.ucm.es/blazars/ebl] I performed some basic changes to the scripts agnpy/absorption/absorption.py and agnpy/tests/test_absorption.py in order to implement and test the new model.