cosimoNigro / agnpy

Modelling jetted Active Galactic Nuclei radiative processes with python
https://agnpy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
47 stars 32 forks source link

Added tests on targets #34

Closed cosimoNigro closed 4 years ago

cosimoNigro commented 4 years ago

This PR adds mote tests on the targets.py submodule.

sourcery-ai[bot] commented 4 years ago

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.04 out of 10.

Before After Change
Quality 8.65 8.68 0.04
Complexity 0.63 0.45 -0.18
Method Length 58.71 56.89 -1.82
Lines 488 699 211
Changed files Quality Before Quality After Quality Change
agnpy/targets.py 8.34 8.34 0.0
agnpy/tests/test_targets.py 9.23 8.99 -0.24 ⬇️

Here are some functions in these files that still need a tune-up:

File Function Quality Recommendation
agnpy/targets.py SSDisk.__init__ 4.9 Split out functionality
agnpy/targets.py SSDisk.u 6.85 Split out functionality
agnpy/targets.py SSDisk.sed_flux 7.0 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

codecov[bot] commented 4 years ago

Codecov Report

Merging #34 into master will increase coverage by 4.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   78.23%   82.25%   +4.01%     
==========================================
  Files          12       12              
  Lines        1190     1279      +89     
==========================================
+ Hits          931     1052     +121     
+ Misses        259      227      -32     
Flag Coverage Δ
#unittests 82.25% <100.00%> (+4.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agnpy/targets.py 77.38% <100.00%> (+19.04%) :arrow_up:
agnpy/tests/test_targets.py 100.00% <100.00%> (ø)
agnpy/tests/test_spectra_emission_regions.py 100.00% <0.00%> (ø)
agnpy/spectra.py 69.07% <0.00%> (+1.94%) :arrow_up:
agnpy/emission_regions.py 84.61% <0.00%> (+2.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7752d3...a891a17. Read the comment docs.