Closed jsitarek closed 3 years ago
β Merging this PR will decrease code quality in the affected files by 0.02%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 2.63 β | 2.63 β | 0.00 |
Method Length | 66.46 π | 68.32 π | 1.86 π |
Working memory | 13.10 π | 13.31 π | 0.21 π |
Quality | 64.39% π | 64.37% π | -0.02% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 410 | 410 | 0 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
agnpy/targets/targets.py | 64.39% π | 64.37% π | -0.02% π |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
agnpy/targets/targets.py | SSDisk.__init__ | 12 π | 212 β | 14 π | 39.42% π | Try splitting into smaller methods. Extract out complex expressions |
agnpy/targets/targets.py | SSDisk.u | 1 β | 148 π | 16 β | 53.14% π | Try splitting into smaller methods. Extract out complex expressions |
agnpy/targets/targets.py | RingDustTorus.__init__ | 2 β | 92 π | 22 β | 54.76% π | Extract out complex expressions |
agnpy/targets/targets.py | SphericalShellBLR.u | 1 β | 136 π | 14 π | 56.85% π | Try splitting into smaller methods. Extract out complex expressions |
agnpy/targets/targets.py | SSDisk.sed_flux | 0 β | 132 π | 14 π | 58.32% π | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
Merging #59 (c64ee20) into master (04786cc) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 30 30
Lines 1718 1718
=======================================
Hits 1618 1618
Misses 100 100
Flag | Coverage Ξ | |
---|---|---|
unittests | 94.17% <ΓΈ> (ΓΈ) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Ξ | |
---|---|---|
agnpy/targets/targets.py | 79.66% <ΓΈ> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 04786cc...c64ee20. Read the comment docs.
copied the relative line intensities from Finke's paper. This will be useful in actually using the absorption classes, because you need to loop over all the lines.