cosimoNigro / agnpy

Modelling jetted Active Galactic Nuclei radiative processes with python
https://agnpy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
47 stars 32 forks source link

Table of relative line intensities #59

Closed jsitarek closed 3 years ago

jsitarek commented 3 years ago

copied the relative line intensities from Finke's paper. This will be useful in actually using the absorption classes, because you need to loop over all the lines.

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 2.63 ⭐ 2.63 ⭐ 0.00
Method Length 66.46 πŸ™‚ 68.32 πŸ™‚ 1.86 πŸ‘Ž
Working memory 13.10 😞 13.31 😞 0.21 πŸ‘Ž
Quality 64.39% πŸ™‚ 64.37% πŸ™‚ -0.02% πŸ‘Ž
Other metrics Before After Change
Lines 410 410 0
Changed files Quality Before Quality After Quality Change
agnpy/targets/targets.py 64.39% πŸ™‚ 64.37% πŸ™‚ -0.02% πŸ‘Ž

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
agnpy/targets/targets.py SSDisk.__init__ 12 πŸ™‚ 212 β›” 14 😞 39.42% 😞 Try splitting into smaller methods. Extract out complex expressions
agnpy/targets/targets.py SSDisk.u 1 ⭐ 148 😞 16 β›” 53.14% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions
agnpy/targets/targets.py RingDustTorus.__init__ 2 ⭐ 92 πŸ™‚ 22 β›” 54.76% πŸ™‚ Extract out complex expressions
agnpy/targets/targets.py SphericalShellBLR.u 1 ⭐ 136 😞 14 😞 56.85% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions
agnpy/targets/targets.py SSDisk.sed_flux 0 ⭐ 132 😞 14 😞 58.32% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

codecov[bot] commented 3 years ago

Codecov Report

Merging #59 (c64ee20) into master (04786cc) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          30       30           
  Lines        1718     1718           
=======================================
  Hits         1618     1618           
  Misses        100      100           
Flag Coverage Ξ”
unittests 94.17% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
agnpy/targets/targets.py 79.66% <ΓΈ> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 04786cc...c64ee20. Read the comment docs.